search

jaakkopasanen / AutoEq

Automatic headphone equalization from frequency responses
MIT License
13.2k stars 2.47k forks source link

App doesn't produce convolutional Eq WAV file with the selected sample rate #668

Closed AlexSKaye closed 1 year ago

AlexSKaye commented 1 year ago

Just came back to this repo to find you've built a full fledged (and smooth) app out of it. Amazing! Unfortunately, I've noticed that no matter what the sample rate is set to in the 'Convolutional Eq' settings, the downloaded WAV file is always 48k. Bit depth and stereo options seem to work ok, and the base64 data under the 'fir' key returned from /equalize seems to vary with sample rate.

Skorrr commented 1 year ago

Just came to say I also bumped into this issue. IR sample rate doesn't match the one chosen in the UI indeed. Also I may add the 32 bit option is actually 32 bit floating point so it should be named acordingly. And it would be awesome to have a 24 bit option as well. Thank you to all contributors for this wonderful webapp!

jaakkopasanen commented 1 year ago

Good catch and thanks for reporting. I'll fix this shortly.

jaakkopasanen commented 1 year ago

This is fixed now 🎉

The problem was AudioContext resampling the audio data automatically when decoding.