search

jaakkopasanen / AutoEq

Automatic headphone equalization from frequency responses
MIT License
12.87k stars 2.47k forks source link

Negative gain values in --bass-boost and --treble-boost produce error #769

Closed eduardoeae closed 4 months ago

eduardoeae commented 4 months ago

Using a negative gain in --bass-boost and --treble-boost, with all three arguments (gain,frequency,quality) fail with the error: __main__.py: error: argument --treble-boost: expected one argument

Using a negative gain only (without frequency and quality) works fine.

jaakkopasanen commented 4 months ago

Can you share the full command you've used?

eduardoeae commented 4 months ago

For example (just tried it):

python -m autoeq --input-file "measurements/KZ ZSN Pro.csv" --output-dir "/tmp/autoeq.tmp" --target "targets/Harman IE.csv" --treble-boost -2,10000,0.7 --tilt -1.0 --treble-f-lower 4500 --treble-f-upper 9000

The exact same command, using a positive gain for the treble, does not cause an error.

jaakkopasanen commented 4 months ago

Python's argument parser doesn't like this for some reason. This is out of my hands since I'm not going to implement my own argparser.

You can work around this by using --treble-boost=-2,10000,0.7.