jaames / iro.js

🎨 Modular color picker widget for JavaScript, with support for a bunch of color formats
https://iro.js.org
Mozilla Public License 2.0
1.32k stars 82 forks source link

Wrong TS declaration of id at ColorPickerProps #251

Open th1nkgr33n opened 1 year ago

th1nkgr33n commented 1 year ago

Hey, I had some starting issues to setup the ts properly using your library. In the end this was the last puzzle piece and I thing the type of the id inside ColorPickerProps shouldn't be null instead it should be a string?

export interface ColorPickerProps extends IroColorPickerOptions {
  display?: string;
  id?: null; <<<---- shouldn't this be a string?
  layout?: ColorPickerLayoutDefinition[] | ColorPickerLayoutShorthand;
  colors?: IroColorValue[];
  transparency?: boolean;
  margin: number;
}