jaanauati / hyper-search

Search-text plugin for Hyper.js
173 stars 21 forks source link

Looks crap on Windows #39

Closed johnknoop closed 5 years ago

johnknoop commented 6 years ago

image

erkattak commented 6 years ago

Same on linux image

divyanshu013 commented 5 years ago

The alignment is also off in Fedora screenshot from 2018-11-09 14-57-04

AaronAsAChimp commented 5 years ago

I was able to fix most of the visual issues by adding this to my '.hyper.js'. I don't think much that can be done about the emojis without a PR.

module.exports = {
    css: `
      .hyper-search-wrapper {
        display: flex;
      }

      .hyper-search-wrapper button {
        position: static !important;
      }
    `
}

image

thomasfedb commented 5 years ago

Currently looks like this on fedora:

image

jaanauati commented 5 years ago

unfortunately I don't have Windows or linux envs handy, will try to pull a vm and test this in the following weeks.

jaanauati commented 5 years ago

hyper-search v0.3.0 has been published to npm; this version has some styling improvements and fixes that seem to address the issues reported in this ticket (see https://github.com/jaanauati/hyper-search/pull/67... thank you @ng-hai !!!!).

See my screenshot, I tested in a windows virtual machine and it seems like the issues have been fixed:

Screen Shot 2019-07-09 at 18 42 57

@thomasfedb can u please let me know if this is also fixing the issues for linux?

thanks

thomasfedb commented 5 years ago

@jaanauati appears resolved on Linux (Fedora) also.

jaanauati commented 5 years ago

thank you @thomasfedb !