Doesn't work after HyperJS update

jaanauati / hyper-search

Search-text plugin for Hyper.js

173 stars 21 forks source link

Doesn't work after HyperJS update #42

Closed MircoT closed 5 years ago

MircoT commented 5 years ago

HyperJS version: 2.1.3

Plugins:

hyper-pane 2.1.3,

hyper-night-owl 1.1.0,

hyper-search 0.0.10

OS: macOS Mojave 10.14.2

Error:

Uncaught TypeError: term.getRowCount is not a function
    at HyperSearchTerm.legacySearch (.../.hyper_plugins/node_modules/hyper-search/src/containers.js:312)

It seems that term doesn't have anymore that function. If you substitute getRowCount with the attribute rows then you will have a problem with getNode function, that is not available too.

m-grzybek-first10 commented 5 years ago

I'm getting the same error

HyperJS version: 2.1.0
Plugins: 
  hyper-material-theme (2.0.8),
  hyper-search (0.0.10)
OS: MacOS High Sierra 10.13.6

jaanauati commented 5 years ago

Sorry abt the delay, I just merged some changes to deal with some breaking changes made at hyperjs side. (https://github.com/jaanauati/hyper-search/pull/43), will be pushing the new version to npm soon.

jaanauati commented 5 years ago

@m-grzybek-first10 @MircoT, v0.0.11 has been published to the npm registry, please give it a try and let me know. thanks!.

m-grzybek-first10 commented 5 years ago

@jaanauati works like a charm :) thanks a lot !

MircoT commented 5 years ago

Also for me! Thanks @jaanauati !