search

jaanauati / hyper-search

Search-text plugin for Hyper.js
173 stars 21 forks source link

Update cmd + f to open and focus input & esc to close input #Suggestion #74

Open ldexterldesign opened 4 years ago

ldexterldesign commented 4 years ago

Hi,

Hope you're well

Thanks for software

As title

Steps to reproduce issue

n/a

Unexpected behaviour

Currently, cmd + f toggles (i.e. open/close) input

Expected behaviour

cmd + f to open and focus input esc to close input

This is how everything else works in macOS (e.g. Finder, Vivaldi, VSCodium) - please utilise this convention

If you're reading and:

If documentation exists (to configure this) then please provide URL or else consider creating some

If you have any issues (e.g. questions/queries) then happy to help

Yours hopefully

hardware: Apple, MacBook Pro (16-inch, 2019) software - operating system: Apple, macOS, 10.15.3 (19D76) software - application: Hyper 3.0.2 (stable)

jaanauati commented 4 years ago

hi @ldexterldesign!, hope u are doing well!, it's not clear for me what the issue is, ... is the problem that the search dialog is not showing up when pressing cmd+f?. thanks

ldexterldesign commented 4 years ago

No, the search is showing up, it's just the interaction I suggest you improve

Possibly a language/translation issue because not sure how much clearer I can be

The important part of my request...

Currently, cmd + f toggles (i.e. opens/closes) the search input but I suggest instead that cmd + f opens the input and esc closes the input

Hope this is clear(er) and to hear back

Thanks