jaanauati / hyper-search

Search-text plugin for Hyper.js
173 stars 21 forks source link

[BUG] emoji magnifier appearing with some themes #80

Closed jukrb0x closed 3 years ago

jukrb0x commented 3 years ago

plugins Info

❯ hyper ls          
hyper-drop-file
hyper-tabs-enhanced
git-falcon9
hyperalfred
hyperlinks
hyper-night-owl
hyper-search
hyper-quit

❯ hyper version
3.0.2

currently using the theme hyper-night-owl and the hyper-search got wrong.

Recurrence magnifier emoji

when Cmd+F pressed, it looks like this:

IMAGE 2020-12-15 02:04:51

what a crap, I started to debug and found the css related to pseudo-element here after hyepr-search-wrapper

well, this section of css isn't shown in the plugin source code, so I don't know what happened actually.

image

Quick fix (trade-off)

Write a new line of css to cover it up, just a trade-off.

I fixed the margin by adding this to containerStyles.js

.${STYLE_CLASSES.wrapper}::before {
        margin: 0 0 0 7px;
      }

And it looks way better, but still not what I want.

IMAGE 2020-12-15 02:15:17

jukrb0x commented 3 years ago

Final

So I presume there's a ghost, but I am an atheist. The 🔍 must be found somewhere so I made a big move, search in node_modules

Well, the truth is revealed... what the heck theme will modify this plugin itself.. (actually, many themes adapted themselves to hyper-search)

image

Case closed!