search

jab416171 / Android-Battleship-Client

Networked Battleship for Android!
3 stars 4 forks source link

Unused classes & duplicate code #2

Closed jab416171 closed 13 years ago

jab416171 commented 13 years ago

All 3 of these classes basically do the same thing. We should either delete two of them or abstract the XML to another class.

@glenwatson @brentlee

glenwatson commented 13 years ago

The HardCodedXML.java and ModelGeneratedXML.java won't do the same thing once we get the model working, theoretically.

glenwatson commented 13 years ago

That's so boss that github figured out I was talking about this issue in a commit comment.

jab416171 commented 13 years ago

It said "as per Issue #2 raised by @jab416171." Did you manually write that?

glenwatson commented 13 years ago

I did write that but it was just in vim. And by the looks of your comment it linked pound + 2 to the 2nd issue. That's cool.