Merge the new version of CommentCoreLibrary with enhanced APIs - Githubissues

jabbany / CommentCoreLibrary

Javascript Live Comment (Danmaku) Engine Implementation. JS弹幕模块核心，提供从基本骨架到高级弹幕的支持。

http://jabbany.github.io/CommentCoreLibrary/demo

MIT License

1.9k stars 304 forks source link

Merge the new version of CommentCoreLibrary with enhanced APIs #63

Closed jabbany closed 7 years ago

jabbany commented 7 years ago

This is the branch for v0.11.0 with a new CommentProvider interface system for loading comments. This version provides:

Better Acfun comment compatibility
Better modularized system for parsers
Revised CommentFilter
Multiple cleanups of unused resources
Documentation fixes
Output location now conforms to npm conventions using dist/
Better Code Danamku support on KagerouEngine

Some roadblocks currently:

~~Rebasing the CSS only version on this branch so we can use the much faster CSS rendering in the future.~~ (Done)
Needs more tests to bring coverage up!

coveralls commented 7 years ago

Coverage decreased (-8.5%) to 64.306% when pulling eacfb367f0d9bfd60ac8b02c44c53f225ee6947d on dev-new-loader into 684d54cc343a99706d1dd21a5b969487d7d60c9a on master.

coveralls commented 7 years ago

Coverage decreased (-8.1%) to 64.666% when pulling 80145cab1141836b8a47bdb95ff9b91cfcc86cc8 on dev-new-loader into 684d54cc343a99706d1dd21a5b969487d7d60c9a on master.

coveralls commented 7 years ago

Coverage decreased (-0.5%) to 72.297% when pulling 6a2bd3a41dccc21068fa6bb06fc0ecf6353ec96e on dev-new-loader into 684d54cc343a99706d1dd21a5b969487d7d60c9a on master.

coveralls commented 7 years ago

Coverage increased (+1.2%) to 73.938% when pulling 6874e37e3dc54da8ede7db8f5acc88279252be74 on dev-new-loader into 684d54cc343a99706d1dd21a5b969487d7d60c9a on master.

coveralls commented 7 years ago

Coverage increased (+1.8%) to 74.623% when pulling 7eb76b263e9bb97e37b981af635480b302c2ed56 on dev-new-loader into 684d54cc343a99706d1dd21a5b969487d7d60c9a on master.

coveralls commented 7 years ago

Coverage increased (+1.8%) to 74.623% when pulling 16eafd62c65b49299d87e5389063fd1d7003afd7 on dev-new-loader into 684d54cc343a99706d1dd21a5b969487d7d60c9a on master.

coveralls commented 7 years ago

Coverage decreased (-12.4%) to 60.424% when pulling e832a0f3017ab78d32a55dcb508681a1959b1aee on dev-new-loader into 684d54cc343a99706d1dd21a5b969487d7d60c9a on master.

coveralls commented 7 years ago

Coverage decreased (-12.4%) to 60.383% when pulling 03ed03b78f30b965fb92cac61bbe792947335126 on dev-new-loader into 684d54cc343a99706d1dd21a5b969487d7d60c9a on master.

coveralls commented 7 years ago

Coverage decreased (-10.1%) to 62.653% when pulling 2b1cf3a48c0f08c0d9d60229be40f6b474bcb8a2 on dev-new-loader into 684d54cc343a99706d1dd21a5b969487d7d60c9a on master.

coveralls commented 7 years ago

Coverage increased (+2.7%) to 75.519% when pulling a183c9a31ecdd4c526a4c82146259fe7c3c2cae9 on dev-new-loader into 684d54cc343a99706d1dd21a5b969487d7d60c9a on master.

coveralls commented 7 years ago

Coverage decreased (-7.9%) to 64.865% when pulling 3a53b2c30e39ef558cd7c226c55d6417bf1d7f5b on dev-new-loader into 684d54cc343a99706d1dd21a5b969487d7d60c9a on master.

coveralls commented 7 years ago

Coverage increased (+1.05%) to 73.84% when pulling 3d3d0cd513032ba634e6e4173418af11f9d91bb0 on dev-new-loader into 684d54cc343a99706d1dd21a5b969487d7d60c9a on master.

coveralls commented 7 years ago

Coverage increased (+1.05%) to 73.84% when pulling 2469643af16b917893a545cc8cefaa317befaa57 on dev-new-loader into 684d54cc343a99706d1dd21a5b969487d7d60c9a on master.

coveralls commented 7 years ago

Coverage increased (+3.3%) to 76.134% when pulling 0319e51acd23626a932206ffaa77bf5c272ee06f on dev-new-loader into 684d54cc343a99706d1dd21a5b969487d7d60c9a on master.

coveralls commented 7 years ago

Coverage increased (+3.3%) to 76.134% when pulling da225a3c56783ec22d4f3dde1f49527019e09421 on dev-new-loader into 684d54cc343a99706d1dd21a5b969487d7d60c9a on master.

coveralls commented 7 years ago

Coverage increased (+3.3%) to 76.134% when pulling fefb62b2087c2105e1cd95d3a4409e1fd59940d1 on dev-new-loader into 684d54cc343a99706d1dd21a5b969487d7d60c9a on master.

coveralls commented 7 years ago

Coverage increased (+3.3%) to 76.114% when pulling 2dc8a850c7cf14c34532eb17c219de3c39b2e39d on dev-new-loader into 684d54cc343a99706d1dd21a5b969487d7d60c9a on master.

coveralls commented 7 years ago

Coverage increased (+0.9%) to 73.676% when pulling 99748311e1e7850da736f9b43785c3b1918b32cd on dev-new-loader into 684d54cc343a99706d1dd21a5b969487d7d60c9a on master.

coveralls commented 7 years ago

Coverage increased (+0.9%) to 73.676% when pulling 2284bd6625a4e4df04016b832c5a666f771a2544 on dev-new-loader into 684d54cc343a99706d1dd21a5b969487d7d60c9a on master.

coveralls commented 7 years ago

Coverage increased (+0.9%) to 73.676% when pulling 57fdb60932e8bf6f976909cec5f9475881b88fa7 on dev-new-loader into 684d54cc343a99706d1dd21a5b969487d7d60c9a on master.

coveralls commented 7 years ago

Coverage increased (+0.9%) to 73.676% when pulling 3a9580723e6db8f0484c110332ce65d4ef8b4d1d on dev-new-loader into 684d54cc343a99706d1dd21a5b969487d7d60c9a on master.

coveralls commented 7 years ago

Coverage increased (+0.8%) to 73.564% when pulling 28e8f6a08cff52098c00d7d1cbb8540caa5bbfb3 on dev-new-loader into 684d54cc343a99706d1dd21a5b969487d7d60c9a on master.

coveralls commented 7 years ago

Coverage increased (+0.8%) to 73.564% when pulling c17c05cb281fcb0a270d815422faa26cd1e6c92d on dev-new-loader into 684d54cc343a99706d1dd21a5b969487d7d60c9a on master.

jabbany commented 7 years ago

This is almost good...

coveralls commented 7 years ago

Coverage increased (+0.8%) to 73.564% when pulling 71afc6f5bd2720f3ce8f48169b0709c87ef35357 on dev-new-loader into 684d54cc343a99706d1dd21a5b969487d7d60c9a on master.