search

jabber-tools / cognitive-services-speech-sdk-rs

Apache License 2.0
24 stars 15 forks source link

EmbeddedSpeechConfig #5

Closed mzachar closed 2 years ago

mzachar commented 2 years ago

Created Rust API to EmbeddedSpeechConfig which is present in the Microsoft SDK header files

see #3 for more info

adambezecny commented 2 years ago

hi,

I will try to review this or next week but I think this will be already easy stuff, the hard work is already done :)

Just couple of comments:

  1. I would like to get more info about embedded model so that new example can be tested easily and it is clear how to use this new feature.
  2. We should add updated documentation here: https://github.com/jabber-tools/jabber-tools.github.io/tree/master/cognitive_services_speech_sdk_rs/doc under new version folder
  3. what do you think new version should be? 0.1.5 or rather 0.2.0?
adambezecny commented 2 years ago

hi Matej,

any progress on this? What is crucial to finish this PR is to provide working example of embedded model so that we can include it into example/document it.

mzachar commented 2 years ago

Sadly I can't provide more info other than whats available in the public SDK headers. There is an example using the embedded speech provided but to run that example you need files from Microsoft.

I'm happy to keep this pull request open until this features get publicly available.

In the mean time if someone has access and want to try out the Rust Embedded Speech API they can just add this as dependency:

[dependencies]
cognitive-services-speech-sdk-rs = { git = "https://github.com/mzachar/cognitive-services-speech-sdk-rs.git", branch = "embedded" }

And setup the required environment variables to point to the speech files and copy new libraries to link against (as libraries from SDK are not enough).

adambezecny commented 2 years ago

we will probably not get any additional info at the moment since it simply does not exist. See this: https://github.com/Azure-Samples/cognitive-services-speech-sdk/issues/1647

I am eager to merge anyway. Can you provide more details what you mean by this sentence: "And setup the required environment variables to point to the speech files and copy new libraries to link against (as libraries from SDK are not enough)." ?

what env. variables and new libraries do you mean? I am under impression there is no way how to run embedded example at the moment because model file is not available (neither no info how to create it). or am I missing something?

adambezecny commented 2 years ago

hi Matej,

I have merged the PR and created new version 0.2.0. Thank you for all your time and effort put into this! It is greatly appreciated. Let's see when Microsoft will add the support for embedded models. I am really eager to play with it. Have a great time and if you come up wit some good idea feel free to raise the PR:) Also bringing into your attention another library I am working on (and which was recently also upgraded to 0.2.0). See here.

regards,

Adam