search

jabbera / my-vsts-tasks

20 stars 18 forks source link

Stopping Windows Service log output lacks Service Names #41

Closed PaulMEdwards closed 5 years ago

PaulMEdwards commented 6 years ago

I noticed that the log output for the Stop Service command no longer displays the Name(s) of the Service(s) being Stopped...

image

It is a simple variable name problem... The variable is initialized as plural:

https://github.com/jabbera/my-vsts-tasks/blob/2d388dd7eb2c14d69073b50239e9b621defdd54b/Extensions/WindowsServiceReleaseTasks/Src/Tasks/StopWindowsService/StopWindowsService.ps1#L7

But the line that prints the message is singular:

https://github.com/jabbera/my-vsts-tasks/blob/2d388dd7eb2c14d69073b50239e9b621defdd54b/Extensions/WindowsServiceReleaseTasks/Src/Tasks/StopWindowsService/StopWindowsService.ps1#L14

I will submit a PR fix shortly...

jabbera commented 5 years ago

Thanks. I did a new PR to avoid the merge commit. I'll post a new version this week.