search

jabbera / vsts-authenticode

A task to authenticode sign dlls
MIT License
7 stars 4 forks source link

FeatureRequest: multiple algos in one go #8

Closed dviry closed 6 years ago

dviry commented 6 years ago

We are signing our .exe files with both SHA1 AND SHA256 (as Microsoft does to all their .EXEs), I currently need to setup 2 Tasks in order to do this - would be a great addition to have them both signed at the same time (maybe a new Algo choice "SHA1 & SHA256").

Thanks

jabbera commented 6 years ago

I didn’t know you could even do this. I’ll sort it.

jabbera commented 6 years ago

How does the timestamping algo and file algo mix with this? IE: what combinations should be supported?

dviry commented 6 years ago

good question - I am just setting either both to SHA1 or to SHA256, it's been working fine so far...

jabbera commented 6 years ago

Alright. I can't think of a reason to mix and match so I'm likely to combine the two options into 1 for simplicity.

jabbera commented 6 years ago

This turned out to be really invasive compared to all the other work I've done on this task today. I'm not going to implement it, but am happy to take a PR if you find the time.