search

jabedude / ofiles

Small library for associating processes and open files
BSD 3-Clause "New" or "Revised" License
9 stars 5 forks source link

Clean up code, improve test coverage and expose /proc/ reading code publicly #7

Open timthelion opened 2 years ago

timthelion commented 2 years ago

Thanks for catching that. I applied the change and all checks are passing.

timthelion commented 2 years ago

Anything else that needs to be done to get this merged?

timthelion commented 2 years ago

Just realized that POSIX uses signed i32s for Pids. So I switched over so that it is easy to use this with, for example, the nix package ;) https://docs.rs/nix/0.25.0/nix/pty/type.SessionId.html

jabedude commented 2 years ago

Looks like a test failure related to your latest commit

timthelion commented 2 years ago

Yeah, I think I fixed the tests now. Sorry about that. It turns out that things are a bit more complicated with the pid_ts than I thought: https://github.com/gradesta/gradesta/blob/95f39e4e53f8187f99408e34b3d089862ab830df/gradesta-s.r.o.-commercial-stuff/web/content/blog/stream4.md#part-8-ofiles-tests

jabedude commented 2 years ago

tests::test_symlink_basic 106 is failing