jabelar / MovingLightSource-1.12

Jabelar's Moving Light Sources Mod
https://minecraft.curseforge.com/projects/jabelars-moving-light-sources
4 stars 2 forks source link

Kill TileEntity instantly. #16

Open V10lator opened 6 years ago

V10lator commented 6 years ago

There doesn't seem to be a reason to keep it alive other than adding a weird trail of light to the player, so let's remove it.

jabelar commented 6 years ago

Actually there is a reason, and yes it is sort of "to leave a trail". The problem is that for entities that are moving quickly, the creation/deletion updates of the tile entities cannot keep up and so create a flashing effect. So in the cases of entities moving away I let them linger. The side effect is indeed a trail but seems to help with flicker.

Actually the value of 4 used to be 2, but I increased it to try to address people complaining about flicker.

The interesting thing is that I personally don't get flicker. So I'm trying to figure out whether it is due to networking lag, or general performance lag, or something logical causing some people to see flicker.

Probably the biggest issue I've had with really optimizing this mod is that I don't see some of the problems other people do -- I have good computer with good networking.

The key is to figure out how to solve issue #15. This death timer was intended to help smooth out issues with flickering.

I'm wondering if maybe I should create the tile entities on the client as well. I'm not sure how Minecraft really handles that, but flickering might be result of network delay to create the next tile entity so maybe it can be bridged by client logic creating the blocks or something...I'm open to ideas.