search

jaberg / skdata

Data sets for machine learning in Python
http://jaberg.github.com/skdata/
474 stars 149 forks source link

Fix setup.py to include data directories as package data #62

Closed hannes-brt closed 10 years ago

hannes-brt commented 10 years ago

The setup.py file is leaving out package data. This makes sure that setuptools copies all the datasets in data/.

jaberg commented 10 years ago

Thanks Hannes! I just had a quick look and there are a few more files in the iris/ and images/ folders. Should those be added to that list of directories? Those dirs have Python files in them too. (Any recommendation for how to lay files & data out?)

hannes-brt commented 10 years ago

Ok, I added those too, along with tests/*.xml. You might also want to add init.py to skdata/mnist/tests to skdata/utils/tests, so those get installed as well.

I think the layout is ok, but I'm not a packaging expert. Just need to keep in mind that by default setuptools only installs Python files and only if there's a init.py in the same directory.

jaberg commented 10 years ago

Thanks! Somehow I missed the message here. Merging your changes, sorry for the delay.