search

jabesq-org / pyatmo

Simple API to access Netatmo weather station data from any python script (for Netatmo information, see www.netatmo.com)
MIT License
27 stars 29 forks source link

feat: expose camera person status #502

Closed adriencog closed 3 months ago

adriencog commented 4 months ago

Add two properties to Person class: out_of_sight & last_seen that we retrieve from home status call

Summary by Sourcery

This pull request introduces new properties out_of_sight and last_seen to the Person class, allowing for tracking of a person's visibility status and last seen timestamp. It also includes updates to the Person class to support these properties and extends existing tests to cover the new functionality.

sourcery-ai[bot] commented 4 months ago

Reviewer's Guide by Sourcery

This pull request introduces two new properties, out_of_sight and last_seen, to the Person class in the pyatmo library. These properties are retrieved from the home status call and are used to update the person's status. The changes include modifications to the Person class, updates to the Home class to handle the new properties, and corresponding test updates.

File-Level Changes

Files Changes
src/pyatmo/person.py
src/pyatmo/home.py		 Added and updated properties out_of_sight and last_seen in the Person class and ensured they are updated in the Home class.
tests/test_camera.py Extended tests to validate the new out_of_sight and last_seen properties in the Person class.
Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.