search

jabranr / noto

Automatically exported from code.google.com/p/noto
0 stars 0 forks source link

Code review request - summarize cjk .otf fonts #317

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Branch name: summary_otf, r7b4c74a8b2ed

Purpose of code changes on this branch: enable summary of .cjk fonts (.otf only 
for now)

When reviewing my code changes, please focus on: is it ok for the linter to 
ignore mac platform name table data?  This was causing summary to fail since it 
uses this code to get the name table values, and the CJK fonts have mac 
platform data in the name table alongside the windows data.

After the review, I'll merge this branch into:
/master

Original issue reported on code.google.com by dougf...@google.com on 31 Mar 2015 at 12:46

GoogleCodeExporter commented 9 years ago

Original comment by dougf...@google.com on 1 Apr 2015 at 10:33

GoogleCodeExporter commented 9 years ago 
Commented at 
https://code.google.com/p/noto/source/detail?r=7b4c74a8b2ed239d4e1e7fa7f098ef439
384a679

Original comment by roozbeh@google.com on 2 Apr 2015 at 3:35

GoogleCodeExporter commented 9 years ago 
refactored, see r7e19fca9ee99

Original comment by dougf...@google.com on 3 Apr 2015 at 12:54