jac-uk / admin

The Vue SPA for managing applications and applicants
https://admin.judicialappointments.digital
MIT License
4 stars 2 forks source link

Feat/admin 2396 create scc eligibility download for legal exercises #2400

Closed KoWeiJAC closed 1 month ago

KoWeiJAC commented 1 month ago

What's included?

closes #2396

Who should test?

✅ Product owner ✅ Developers ✅ UTG

How to test?

Example exercises:

🟢 No risk - this is a self-contained piece of work

Additional context

Include screen grabs, video demo, notes etc.

Related permissions

Have permissions been considered for this functionality?


PREVIEW:DEVELOP can be OFF, DEVELOP or STAGING

github-actions[bot] commented 1 month ago

Visit the preview URL for this PR (updated for commit a1f48ca):

https://jac-admin-develop--pr2400-feat-admin-2396-crea-rjpjdx45.web.app

(expires Fri, 28 Jun 2024 12:34:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

KoWeiJAC commented 1 month ago
  • I've checked the age calculation and it doesn't look quite right - can you confirm which date is being referenced in the calculation in the case of this exercise?

@nickaddy

The SCC age currently is the length between the candidate date of birth and the expected service end date (Eligibility SCC date + reasonable length of service).

For example, if the Eligibility SCC date is 20 June 2024, and the reasonable length of service is 5 years. The expected service end date will be June 2029. If the candidate date of birth is JAN 1980, the SCC age will be 49 years and 7 months old.

Should we use Eligibility SCC date without adding reasonable length of service as reference?

nickaddy commented 1 month ago

@KoWeiJAC Hopefully there are my final comments on the download:

image
KoWeiJAC commented 1 month ago

@nickaddy These places have been updated, could you help me to review them again? Thanks

nickaddy commented 1 month ago

@HalcyonJAC I cannot do a final review on Ko Wei's work because the download appears to be broken - pls repair and let me know when I can retest.