Feat/2423 align admin with section 2d3d qualifications changes

jac-uk / admin

The Vue SPA for managing applications and applicants

https://admin.judicialappointments.digital

MIT License

4 stars 2 forks source link

Feat/2423 align admin with section 2d3d qualifications changes #2457

Closed KoWeiJAC closed 2 days ago

KoWeiJAC commented 1 week ago

What's included?

closes #2423

Who should test?

✅ Product owner ✅ Developers ✅ UTG

How to test?

Go to the preview link: https://jac-admin-develop--pr2457-feat-2423-align-admi-o5n9agb4.web.app/exercise/X2tDg5AKt18xvzBRJFYW/applications/applied/application/g6e7d5gxp7FTEDnrwAPv
Click Edit
Change and save the answer for Are you applying under Schedule 2(3)?
- If the answer is Yes, it should appear None of above option for Qualification
- If the answer is No, it should not appear None of above option for Qualification
- If the answer is changes, the Qualification(s) should be reset

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Include screen grabs, video demo, notes etc.

Related permissions

Have permissions been considered for this functionality?

No permission changes required
Permissions have been added / updated. Details:

PREVIEW:DEVELOP can be OFF, DEVELOP or STAGING

github-actions[bot] commented 1 week ago

Visit the preview URL for this PR (updated for commit 779aafd):

https://jac-admin-develop--pr2457-feat-2423-align-admi-o5n9agb4.web.app

_{(expires Fri, 26 Jul 2024 16:24:17 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0}

nickaddy commented 1 week ago

@KoWeiJAC This is not working for me. First of all, there was no option set under eligibility in set-up (you have to choose 2d or 2(3). I've now set it to 2d and at that point the Are you applying under section 2d appeared. However, irrespective of my answer, None of the above appears in the dropdown. Also, it doesn't appear to reset when the initial answer to Are you applying under... changes.

KoWeiJAC commented 1 week ago

I would have thought when you click 'No' the window below (Explain how etc) should not appear. It should only appear when you click 'Yes', which allows the candidate to explain how they gained their experience in law..

@Franceswog I've had a change for it can remove 'Explain how...' question after selecting 'No' for the schedule question. Originally, it remove the 'Explain how...' after click 'save' for the schedule question. Could you help me to confirm if it is ok ? Thanks

https://github.com/jac-uk/admin/assets/156695133/b6dfb93b-88fa-4c2c-9349-87ca007154b2

KoWeiJAC commented 1 week ago

@KoWeiJAC This is not working for me. First of all, there was no option set under eligibility in set-up (you have to choose 2d or 2(3). I've now set it to 2d and at that point the Are you applying under section 2d appeared. However, irrespective of my answer, None of the above appears in the dropdown. Also, it doesn't appear to reset when the initial answer to Are you applying under... changes.

@KoWeiJAC This is not working for me. First of all, there was no option set under eligibility in set-up (you have to choose 2d or 2(3). I've now set it to 2d and at that point the Are you applying under section 2d appeared. However, irrespective of my answer, None of the above appears in the dropdown. Also, it doesn't appear to reset when the initial answer to Are you applying under... changes.

@nickaddy Not sure if the exercise being reset, I set it to schedule 2(3) originally, thank you for fixing it.

I've had following changes:

'None of above' appears according to schedule question, it will change when schedule being selected not saving.
Reset all the qualifications after the schedule question change saved. Because it will be to safer to reset the qualification after schedule being saved. Could you help me to confirm if it is ok ? Thanks https://github.com/jac-uk/admin/assets/156695133/1c600910-f141-4e1e-aeeb-264daa57fca3