jac-uk / admin

The Vue SPA for managing applications and applicants
https://admin.judicialappointments.digital
MIT License
4 stars 2 forks source link

Feature/2424 Support Reset of Character Report #2459

Closed HalcyonJAC closed 2 days ago

HalcyonJAC commented 1 week ago

What's included?

Closes #2424

Related PR: digital-platform: Feature/admin 2424 Support Reset of Character Report #1123

Who should test?

✅ Product owner ✅ Developers ✅ UTG

How to test?

Example exercise: Ryan test 1 (Character issues)

Note: The "Reset" button is only visible for Digital Super User.

Steps:

  1. Go to the Character Issues report and hit the Reset button.
  2. Check if the data is repopulated from applications.

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Demo:

https://github.com/jac-uk/admin/assets/79906532/a7ad1360-dc27-4b39-928e-ad9c63c8ecf3

Related permissions

New permission: canResetCharacterIssuesReport


PREVIEW:DEVELOP can be OFF, DEVELOP or STAGING

github-actions[bot] commented 1 week ago

Visit the preview URL for this PR (updated for commit 587ad84):

https://jac-admin-develop--pr2459-feature-2424-support-mc5hdyo3.web.app

(expires Sat, 27 Jul 2024 09:41:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

nickaddy commented 6 days ago

@HalcyonJAC I'm finding that I'm able to reset the report by pressing the refresh button, i.e. it's not locked?

HalcyonJAC commented 6 days ago

@HalcyonJAC I'm finding that I'm able to reset the report by pressing the refresh button, i.e. it's not locked?

@nickaddy Thank you for spotting that. I have sorted it. Could you test it again, please?