jac-uk / apply

Vue SPA to allow candidates to apply for judicial vacancies
https://apply.judicialappointments.digital
MIT License
4 stars 0 forks source link

#1212 Single email address on Apply for candidates #1226

Closed drieJAC closed 1 month ago

drieJAC commented 1 month ago

What's included?

Allow dob and nino to be editable only once in the Personal Details section of the application. Once email, dob and nino have values then display the value with a link to the candidate profile section if they wish to edit them.

Closes #1212

Who should test?

✅ Product owner ✅ Developers ✅ UTG

How to test?

https://jac-apply-develop--pr1226-feature-1212-single-9kc7zb7o.web.app/

TEST 1

  1. Login to apply
  2. Apply for a vacancy
  3. In the Personal Details section the email should be displayed as text with a link next to it to edit it in the candidate profile page
  4. In the Personal Details section if the dob is empty then there should be an input which allows you to enter it. Once it's updated it should not be editable in the Personal Details page. It will display as text with a link next to it to edit it in the candidate profile page
  5. In the Personal Details section if the NI Number is empty then there should be an input which allows you to enter it. Once it's updated it should not be editable in the Personal Details page. It will display as text with a link next to it to edit it in the candidate profile page

TEST 2

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Screenshot 2024-09-18 at 11 22 00

PREVIEW:DEVELOP can be OFF, DEVELOP or STAGING

github-actions[bot] commented 1 month ago

Visit the preview URL for this PR (updated for commit 9c96036):

https://jac-apply-develop--pr1226-feature-1212-single-9kc7zb7o.web.app

(expires Sun, 20 Oct 2024 11:25:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d5ac0a9c931657844a433a502135cf38aca21627

nickaddy commented 1 month ago

@drieJAC There is a slight glitch, in that on the preview url when you go to the personal details section, DOB and NINo are initially editable until you go to update then when they revert to non-editable with the link to profile. It's not a problem with DOB because that is a mandatory field when you create a profile, however, NINo isn't, so it needs a fix for first-time candidates that have not yet completed an application or populated the NINo field in their profile. Otherwise works well.

Once it has passed reviews etc, are there any implications to releasing during an application window or should we wait until there are no exercises open for application?

nickaddy commented 1 month ago

Looking good, Omar, thanks for resolving the glitch 👍