jac-uk / apply

Vue SPA to allow candidates to apply for judicial vacancies
https://apply.judicialappointments.digital
MIT License
4 stars 0 forks source link

Feature/1242 2FA - Replace Phone Number With UK Mobile Phone Number #1245

Closed HalcyonJAC closed 2 weeks ago

HalcyonJAC commented 3 weeks ago

What's included?

Closes #1242

Who should test?

✅ Product owner ✅ Developers

How to test?

Preview URL

  1. Log in via the preview URL and go to the "Your profile" page.
  2. Edit the "UK Mobile phone number" field and check if the validation is working.
  3. Apply for an application and go to the "Personal details" section.
  4. Check if there is a link next to the "UK Mobile phone number" field which will redirect to the profile page.

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Demo:

https://github.com/user-attachments/assets/64be3d3c-ca05-486e-b375-f8e46b83d368


PREVIEW:DEVELOP can be OFF, DEVELOP or STAGING

github-actions[bot] commented 3 weeks ago

Visit the preview URL for this PR (updated for commit 67bcc50):

https://jac-apply-develop--pr1245-feature-1242-2fa-rep-fhokfih3.web.app

(expires Wed, 27 Nov 2024 14:34:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d5ac0a9c931657844a433a502135cf38aca21627

nickaddy commented 3 weeks ago

@HalcyonJAC I have assumed that we are not testing the verification at this time. I was able to successfully enter a mobile number without the leading 0 - this should be addressed.

HalcyonJAC commented 2 weeks ago

@HalcyonJAC I have assumed that we are not testing the verification at this time. I was able to successfully enter a mobile number without the leading 0 - this should be addressed.

@nickaddy It has been sorted.