jac-uk / apply

Vue SPA to allow candidates to apply for judicial vacancies
https://apply.judicialappointments.digital
MIT License
4 stars 0 forks source link

Bugfix/TS 438 Character information civil proceedings not saved #1260

Closed HalcyonJAC closed 3 hours ago

HalcyonJAC commented 8 hours ago

What's included?

Related issue: User Raised Issue BR_ADMIN_PR_000242 #438

Who should test?

✅ Product owner ✅ Developers

How to test?

Example vacancy

Steps:

  1. Apply for the vacancy and go to the Character information section.
  2. Check if you can input your record of Civil Proceedings.
  3. Check if your data shows correctly on the review page.

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Demo:

https://github.com/user-attachments/assets/216e416c-b759-4168-a5fc-68fc8d866603


PREVIEW:DEVELOP can be OFF, DEVELOP or STAGING

github-actions[bot] commented 8 hours ago

Visit the preview URL for this PR (updated for commit 8071b01):

https://jac-apply-develop--pr1260-bugfix-ts-438-charac-61cs4b3x.web.app

(expires Sun, 15 Dec 2024 12:41:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d5ac0a9c931657844a433a502135cf38aca21627

nickaddy commented 7 hours ago

@HalcyonJAC We're just testing the review at the end of the character section, right?

I noticed that all 4 tickboxes were pre-ticked; they should all be unticked by default.