search

jac241 / power_hour_creator

A new app to create power hours from Youtube videos
GNU General Public License v3.0
13 stars 11 forks source link

yt-dlp is out of date: fails to download videos #69

Open jroth2 opened 1 year ago

jroth2 commented 1 year ago

Hey, when you go to add a url you get a download error from yt-dlp. The error mentions something about updating your yt-dlp: unable to extract uploader id, but it only shows up for a moment. It leaves you unable to use the application.

The latest version of yt-dlp fixes this issue, but they dropped support for python 3.6. I built it with 3.6.7 but the latest version of yt-dlp I could get had the same error. I managed to build the power_hour_creator with python 3.9.6 and yt-dlp==2023.03.04 and was able to get it to work as intended. I would add a pull request? I think? with this fix but I'm not much of an expert with that.

Thanks, Joe

wellsfletcher commented 1 year ago

Hey Joe, I also noticed this error. Can you create the pull request? Even if the repo owner takes a while to approve it, other people can use the pull request code while the master branch is broken. It could also be helpful if you made your fork public.

noahbecker23 commented 1 year ago

Hey @jroth2, would you be able to create the pull request or explain how you built it specifying the Python and yt-dlp versions to use? Or, as @wellsfletcher mentioned, make your fork public? I am running into the same error and cannot figure out how to build it using a different version of Python or yt-dlp package. Thank you in advance!

lentz commented 1 month ago

@wellsfletcher @noahbecker23 I created a public fork and fixed the issue by upgrading the packages. I submitted a PR with the update and created a public fork with a release of the fixed app for MacOS.