jacek-kurlit / pik

Process Interactive Kill
https://crates.io/crates/pik
MIT License
186 stars 6 forks source link

Add fuzzy search for Path type of queries #76

Closed grouzen closed 1 month ago

grouzen commented 2 months ago

Addresses #2

What

grouzen commented 2 months ago

I don't understand why it fails on mac

jacek-kurlit commented 2 months ago

I don't understand why it fails on mac

I have no idea either, I don't own mac to check it. My guess it .unwind() is blowing up for some reasons.

jacek-kurlit commented 2 months ago

My guess is that for some reason p.cmd_path.as_ref().unwrap() Can you change it to .expect() to see if we are headng in right direction?

grouzen commented 2 months ago

My guess is that for some reason p.cmd_path.as_ref().unwrap() Can you change it to .expect() to see if we are headng in right direction?

Sorry, I don't understand how it may help. I'll try to test it on my partner's MacBook tomorrow :)

grouzen commented 2 months ago

Honestly, I have no clue how to debug this thing. I've tried cargo with gdb -- test --test processes_search, but it doesn't detect the cargo process even on my Linux.

grouzen commented 2 months ago

I've tested it on mac and it seems fuzzy search in general works well on Mac. Don't know why this test fails.

jacek-kurlit commented 1 month ago

I'm clueless, maybe nextest works differently on mac? My other guess is github with mac is somehow so different that on typical mac that test fails? Anyway, can you exclude this test on mac until we will figure out what is going on? Probably this will do the trick #[cfg(not(target_os = "macos"))]

grouzen commented 1 month ago

I'm clueless, maybe nextest works differently on mac?

I've tried to run cargo test which is not running via nextest I believe on my partner's Mac and it failed, so I guess it is not the case.