search

jacek-kurlit / pik

Process Interactive Kill
https://crates.io/crates/pik
MIT License
186 stars 6 forks source link

add `ctrl+arrow up`/`ctrl+arrow down` keybinding to go first/end row #91

Closed wugeer closed 1 month ago

wugeer commented 1 month ago

This PR simply adds support for Home/End keys for moving to first/last row.

jacek-kurlit commented 1 month ago

Hi! Thank you for PR The problem is that Home and End are already taken by tui-textarea create that handles input https://docs.rs/tui-textarea/latest/tui_textarea/#minimal-usage Currently pressing Home and End will move caret at the beginning and end of search input which may be more intuitive that jumping at top and last row in processes table If you find this KyeMap useful you may think about other key combination like Ctrl + g/G

wugeer commented 1 month ago

Hi! Thank you for PR The problem is that Home and End are already taken by tui-textarea create that handles input https://docs.rs/tui-textarea/latest/tui_textarea/#minimal-usage Currently pressing Home and End will move caret at the beginning and end of search input which may be more intuitive that jumping at top and last row in processes table If you find this KyeMap useful you may think about other key combination like Ctrl + g/G

Good idea! But I prefer Ctrl + Up/Down keys to move to the beginning/end, while pressing the Up/Down keys alone represents moving one line. :)