Checked for the name when looking for a key in globals.

jacek99 / javabuilders

Max productivity with minimum code for Java desktop UI development

Other

50 stars 15 forks source link

Checked for the name when looking for a key in globals. #1

Closed kmp1 closed 9 years ago

kmp1 commented 10 years ago

I see this is quite an old project but I'm using it regardless and I noticed...

The original code doesn't seem quite correct in that it is checking for the globals as a key of globals and then throwing an exception saying that name doesn't exist. Checked for name instead.

jacek99 commented 9 years ago

Hi sorry, I just noticed this pull request....had my notifications off. Sorry about that.

I recently wen tthrough a total conversion of the project to move it to Gradle, simplify the project structure and update all the dependencies to more recent versions.

if you could redo this PR against this latest code, it would be much appreciated...thanks!

jacek99 commented 9 years ago

Hi, I integrated this already in the 2.0.0 branch