search

jacekk015 / zha_quirks

All quirks in one place
MIT License
146 stars 20 forks source link

Update ts0601_trv_rtitek2.py #59

Closed ariewtf closed 2 weeks ago

ariewtf commented 1 month ago

added the moes TRV models that works with this quirk.

https://moeshouse.com/products/smart-wifi-thermostatic-radiator-valve-trv-programmable-temperature-controller?variant=49598375231803

you might wanna add them ts0601_trv_rtitek2.py as wel since they work in that quirk also.

jacekk015 commented 3 weeks ago

They aren't the same - compare the code. VALVE_POSITION_ATTR is different so on one of the quirk that value will not work. So you will not have valve opening percentage in HA

ariewtf commented 2 weeks ago

You are right This one works with the Valve Position the other one doesn't you can't change it but it does give you the status.

i'm sure there are more attributes that aren't in this quirk that this Valve has but this is the most functional quirk out there.

jacekk015 commented 2 weeks ago

Valve position is mostly read-only

ariewtf commented 2 weeks ago

i have some debug logging, can i share this somewhere? maybe someone can look into it and maybe can find missing features etc.

jacekk015 commented 1 week ago

You can make sure you have txt extension and drag/drop it to the post window. As for missing features - you have 0.01% of chances Rtitek quirk has over 800 lines of code. Forget about Schedule settings or anything deep.

My Maxsmart TRVs quirk, that I have on my own, have over 2000 lines of python code, and even there I've only programmed Schedule through Zigbee commands. It's not worth the time.