search

jacekkopecky / vscode-whole-diff

Whole Diff extension for VSCode
MIT License
10 stars 2 forks source link

Add an option to pass --no-ext-diff to git #5

Closed ELLIOTTCABLE closed 6 months ago

ELLIOTTCABLE commented 1 year ago

This allows the configuration option git config diff.external to be ignored, if it's using an incompatible program / producing an unexpected format.

I did this on my phone, hopefully I didn't screw it up. 😅

Fixes #4.

jacekkopecky commented 1 year ago

Thanks; I can't find the diffEditor.ignoreExternalDiff option used in your code though, do you mean this to be a new option?

If so, it won't be as simple as this. This extension hasn't needed its own settings yet so we'd need a new section in package.json, see https://code.visualstudio.com/api/references/contribution-points#contributes.configuration, and then possibly some more code somewhere. You can look at how diffViewer has done its settings, I know it has some.

jacekkopecky commented 8 months ago

Hi @ELLIOTTCABLE , are you still interested in this one, or shall I close it?

jacekkopecky commented 6 months ago

Closing for lack of response.