Checks and installs pyusb and confirms compatibility with Latitude 7270

jacekkow / controlvault2-nfc-enable

Enable NFC on Linux for pcscd on Dell E7470 (and others) with ControlVault2

BSD 3-Clause "New" or "Revised" License

78 stars 20 forks source link

Checks and installs pyusb and confirms compatibility with Latitude 7270 #19

Open kalpo opened 2 years ago

kalpo commented 2 years ago

This pull would:

Add a check for pyusb before importing it to handle gracefully failure to load the lib
Allows the user to install the library from the script (using pip)
Redirects the user to the official documentation for pyusb if it fails to install it
Adds a link to the pyusb site on pypi to the readme.md.
Adds to the readme.md file that the script has now been tested on latitude 7270

Feel free to edit all you want. Thanks again for taking the time to make this project happen

kalpo commented 2 years ago

Thank you for taking the time to give such good feedbac. I'll have some time to make those little changes soon.

jacekkow commented 2 years ago

One thing left and I'm ready to merge it.

kalpo commented 2 years ago

This last commit prints to sderr for any inport error. And only specifically tells the user that pyusb is required when it is that library that we they are missing. Happy to delete that bit if you think it is a bit too much info. :)