search

jacekkow / keycloak-protocol-cas

CAS protocol provider for Keycloak
https://issues.jboss.org/browse/KEYCLOAK-1047
Apache License 2.0
92 stars 28 forks source link

Keycloak V25 breaks CAS client-scope creation #119

Open ValentinLorand opened 3 weeks ago

ValentinLorand commented 3 weeks ago

Helloo,

I was very happy to be able to create CAS client scope in keycloak 24.0.4 without any problem but since I upgraded Keycloak to version 25.0.4, I can't create client-scope for protocol CAS.

The CAS choice is present in the creation form but when I submit the form I get a 400 Bad Request response because of the bad protocol value (see the screenshot below) :

image

The problem occurs both from the API and the admin console interface.

Do you have any idea of the origin of this problem and a potential fix in mind ? :)

Best regards, Valentin Lorand

ValentinLorand commented 3 weeks ago

After some digging, I found the origin of the problem :

image

A fragment of code has been implemented in the version 25 of Keycloak where an hardcoded comparison is performed to validated the protocol (SAML or OIDC). This implementation BREAKS the extensibility of Keycloak regarding the protocols.

cf : https://github.com/keycloak/keycloak/pull/29544

jacekkow commented 3 weeks ago

@ValentinLorand - would you report it upstream?

ValentinLorand commented 3 weeks ago

Yes, the issue is created here : https://github.com/keycloak/keycloak/issues/32281