jacekschae / learn-re-frame-course-files

:cinema: Learn re-frame course files for building Cheffy app
https://www.learnreframe.com/
57 stars 43 forks source link

complete version not working properly #14

Open michael-mhrdd opened 3 years ago

michael-mhrdd commented 3 years ago

When running the complete version locally, it differs from app.learnreframe.com: After agreeing to become a chef and adding a recipe, then opening it,

npm install produces these warnings: npm WARN deprecated highlight.js@9.18.5: Support has ended for 9.x series. Upgrade to @latest npm WARN deprecated polished@2.3.3: polished@2.X is no longer supported. Please upgrade to @latest f or important bug and security fixes.

at the end of npm run dev, i get: Warning: Nashorn engine is planned to be removed from a future JDK release

Also, the re-frame-10x tab is strangely formatted:

image

anderskitson commented 2 years ago

As for the re-frame-10x tab what I did to fix that whole UI was

was changing re-frame version in shadow-cljs.edn

to

[day8.re-frame/re-frame-10x "1.2.1"]

and the reagent version to

[reagent "1.1.0"]

this also required me to update the the core.cljs file to the following

(ns app.core
  (:require [reagent.core :as r]
            ;; addition here
            [reagent.dom  :as rd]))

(defn app
  []
  [:div "Cheffy"])

(defn ^:dev/after-load start
  []
  ;; change to rd
  (rd/render [app]
    (.getElementById js/document "app")))

(defn ^:export init
  []
  (start))

remember to stop and start server, either npm run dev or yarn dev

I am also running node 12 so that may help with the node warnings.

As for the functionality of the rest of the features I am not sure, but will message when I get to that part, I have started over because my REPL was way to broken and couldn't fix it.

Anyways hope this is of some help