jacereda / fsatrace

Filesystem access tracer
ISC License
78 stars 12 forks source link

Clarify (or clean up) the Windows makefile #27

Closed ndmitchell closed 5 years ago

ndmitchell commented 5 years ago

While taking a look around I saw in win.mk:

SRCS32=src/win/fsatracedll.c src/win/inject.c src/win/patch.c src/win/hooks.c src/emit.c src/win/shm.c src/win/handle.c src/win/utf8.c src/win/dbg.c src/win/inject.c
SRCS64=$(SRCS32) src/win/inject.c

So SRCS64 = SRCS32 + inject.c. But inject.c is already is SRCS32? Unlikely to be harmful, but I guess it's a mistake?

jacereda commented 5 years ago

Worse than that, it's also replicated in SRCS32 :)

I left SRCS32=SRCS64.

Thanks!