search

jacereda / fsatrace

Filesystem access tracer
ISC License
78 stars 12 forks source link

Improve shm management #46

Closed jayzhuang closed 2 years ago

jayzhuang commented 2 years ago
  1. Add O_EXCL to shm_open to fail early in case a dirty shm from previous run was not cleaned up properly
  2. Return early on failures so errno is not overwritten
jacereda commented 2 years ago

Is this addressing the same problem as https://github.com/jacereda/fsatrace/pull/45 ?

jayzhuang commented 2 years ago

45 might be better than O_EXCL, yes. The return early changes are orthogonal, but I don't feel too strong about including them.