search

jacereda / raytracing-in-one-weekend-carp

6 stars 0 forks source link

FPE.carp #1

Open eriksvedang opened 4 years ago

eriksvedang commented 4 years ago

First of all, this is reall cool! Looking through the code now, looks great :)

I get an error when trying to run it though, says it can't find FPE.carp. Where can I get that file?

jacereda commented 4 years ago

Oops, just comment that line and it should work.

That module allows to detect floating point exceptions and I used it for debugging purposes.

I don't know if that belongs in core or in a separate repo.

eriksvedang commented 4 years ago

OK, thanks – now it works! Really cool.

Regarding FPE – I think it sounds potentially like something we'd want in core. Depends on if it brings in a lot of dependencies and such?

jacereda commented 4 years ago

No dependencies besides libc.

On Tue, Oct 29, 2019 at 1:08 PM Erik Svedäng notifications@github.com wrote:

OK, thanks – now it works! Really cool.

Regarding FPE – I think it sounds potentially like something we'd want in core. Depends on if it brings in a lot of dependencies and such?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jacereda/raytracing-in-one-weekend-carp/issues/1?email_source=notifications&email_token=ABAAMT5MKCQSTFQPSNBZTTLQRARVRA5CNFSM4JGFKLV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECQH7TQ#issuecomment-547389390, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAAMTZD4F4PJHZBZAM27T3QRARVRANCNFSM4JGFKLVQ .