search

jachzen / cunning_document_scanner

MIT License
79 stars 83 forks source link

Add customizability (contribution discussion) #16

Open 3DExtended opened 1 year ago

3DExtended commented 1 year ago

Hey!

Thank you so much for this plugin! It works great.

I would like to contribute to this project and wanted to discuss your preferences first. I want to replace the usage of VNDocumentCameraViewController because I think it is too limiting.

Are you willing to accept a PR which adds a dependency to another open source project? I found this project https://github.com/WeTransfer/WeScan which might be a good fit.

Another option is to implement the scanning with the Vision Kit ourselves.

What are your thoughts on this? Let me know what you think and I might be able to help!

jachzen commented 1 year ago

I need to check wescan before. But Sure that may be a good idea as the Stock iOS Scanner ist very Limited.

akshayindia commented 1 year ago

@3DExtended, have you submitted the PR?

jachzen commented 8 months ago

I think with CIDetector it may be working. I will do some testing and come up with a customimplementation.

nhCoder commented 8 months ago

Yes, we need this feature.