search

jack-broadway / vyos-modular

A build system for vyos that allows you to import local/external modules to customize the build
18 stars 5 forks source link

Refactoring build commands to be compatible with current vyos build branch #1

Closed sophia-ruduke closed 2 years ago

sophia-ruduke commented 2 years ago

Though this PR is set to merge to the main branch, it would be best to create a new feature branch for the changes and merge them there. That way, crux, ami and equuleus builds could still be carried out using the main branch, but current builds can be undergone using the new branch (I called this branch current to match with the vyos-build repo).

jack-broadway commented 2 years ago

Yup this was definitely the direction I intended. I just only run equuleus at the moment :). I'll fix up the repo structure and merge your changes in both repositories

jack-broadway commented 2 years ago

Alright, I have a dev version of these changes in 'saggita-support' branch. My goal for the main 'vyos-modular' repo is to have a single branch so users dont have to choose a branch. I've reimplemented your changes using a builder class per version. Hopefully if building diverges even more in the future this model should be responsive to those changes.

I've done a test build with this branch and your changes in vyos-module-tailscale and all seems well.

jack-broadway commented 2 years ago

Will merge manually