search

jack-cli-cd-ripper / jack

Jack command-line CD ripper
GNU General Public License v2.0
14 stars 5 forks source link

python3-mb: old jack.toc files may list data tracks #30

Open pimzand opened 4 years ago

pimzand commented 4 years ago

Old jack.toc files may list data tracks. Using these toc files in libdiscid to query MusicBrainz will not return valid releases.

pimzand commented 4 years ago

To make it worse, data tracks are listed as audio tracks in jack.toc. But I now found out that they are marked as data tracks in jack.progress, with lines like these:

11/|\off/|\non-audio

This could be used to filter out these tracks when recalculating the discid

pimzand commented 2 years ago

Since commit c6c8c4ebd535f34e0d335b31dc02f899ca4badb2, we now detect toc files containing data tracks, created using older versions of Jack that used CDDB.py. This could still work for freedb/gnudb queries, but never for MusicBrainz.

Ideally, we could just remove the datatracks from the query, but it turns out that CDDB.py, when handling discs with data tracks, gets the length of the last audio track wrong, removing an any chance for a successful MusicBrainz query.