search

jack-cli-cd-ripper / jack

Jack command-line CD ripper
GNU General Public License v2.0
14 stars 5 forks source link

Increase the level of PEP8 compliance #36

Open madarche opened 4 years ago

madarche commented 4 years ago

In the .travis.yml file, there are many exclusions of PEP8 conformance points: --ignore=E501,W604,W601,E721,E402,E711,E713,E741

Those exclusions have no reason apart from the lack of time when this repository was setup in GitHub.

Since the pep8 tool is at the moment the only safeguard, it would be better to use it to its full extent.

pimzand commented 4 years ago

I suppose this is even worse for the python3-mb branch. I would be guilty of that. Maybe we should revert https://github.com/jack-cli-cd-ripper/jack/commit/377bebcc0f663045b6301c994ad7a155e73771bc and https://github.com/jack-cli-cd-ripper/jack/commit/c4cfd919cf75c3c2809277bf37c6edfe1958981b if possible

zzarne commented 4 years ago

Reverting them would be of little help as most of the statements there were too long before those commits. Line continuation was ugly before, and I'm to blame mostly. I think we should just fix what we have, little by little. And wherever possible make the code more readable. This is a valid issue and we should keep it open until fixed.