python3-mb: musicbrainz_template() breaks smart metadata selection

jack-cli-cd-ripper / jack

Jack command-line CD ripper

GNU General Public License v2.0

14 stars 5 forks source link

python3-mb: musicbrainz_template() breaks smart metadata selection #44

Closed pimzand closed 2 years ago

pimzand commented 2 years ago

Before commit 4f709dbfb45549b07afd5f636885a9d24946cc97, jack would use the most recently modified cached metadata (ie, jack.freedb or jack.musicbrainz), regardless of the default metadata provider. This behaviour is now broken when musicbrainz is the default metadata provider, yet jack.freedb is the only available cached metadata. Jack now creates an empty jack.musicbrainz which will then be selected because of its newer modification date, leading to failure.

zzarne commented 2 years ago

should be fixed in https://github.com/jack-cli-cd-ripper/jack/commit/de42206c1076d6f0ab1fbaad7293f2f87e90033d.

I changed metadata_names() so that it

works with any number of scrapers
tests whether the data is usable

while still

selecting the most recent data
informing the user if the source is not the configured source.

Please test.

pimzand commented 2 years ago

Yes, works as expected. Thanks!