search

jack-cli-cd-ripper / jack

Jack command-line CD ripper
GNU General Public License v2.0
14 stars 5 forks source link

python3-mb: group vocal and instrumental performers separately #45

Closed pimzand closed 2 years ago

pimzand commented 2 years ago

The MusicBrainz tagging code was designed with the goal to achieve the exact same results as MusicBrainz Picard would do.

Picard appears to create separate performer tags, when a performer is both credited as vocal performer, and an instrumental performer. Jack currently tags differently.

This can be seen in this release. https://musicbrainz.org/release/94bc2804-ff37-32d0-9d01-6c5f63185d2f

Jack creates these vorbiscomment tags:

PERFORMER=John Acock (harmonium, mellotron and piano)
PERFORMER=Phil Collins (guest, membranophone, percussion, vibraphone and additional)
PERFORMER=John Hackett (bell, flute, guest and synthesizer)
PERFORMER=Steve Hackett (acoustic guitar, autoharp, bell, electric guitar, harmonium, mellotron and vocals)
PERFORMER=Robin Miller (cor anglais and oboe)
PERFORMER=Mike Rutherford (12 string guitar, bass guitar, bass pedals and guest)
PERFORMER=Nigel Warren-Green (cello and solo)

Picard would use these tags:

PERFORMER=John Acock (harmonium, mellotron and piano)
PERFORMER=Phil Collins (guest membranophone, percussion and vibraphone)
PERFORMER=John Hackett (guest bell, flute and synthesizer)
PERFORMER=Steve Hackett (acoustic guitar, autoharp, bell, electric guitar, harmonium and mellotron)
PERFORMER=Robin Miller (cor anglais and oboe)
PERFORMER=Mike Rutherford (guest 12 string guitar, bass guitar and bass pedals)
PERFORMER=Nigel Warren-Green (solo cello)
PERFORMER=Phil Collins (additional vocals)
PERFORMER=Steve Hackett (vocals)

Note the special handling of the word "guest".

pimzand commented 2 years ago

fixed in commit 90865b45366a04269058ebf449cf5c8b8fa8d7ad