search

jack-cli-cd-ripper / jack

Jack command-line CD ripper
GNU General Public License v2.0
14 stars 5 forks source link

do we still need and want to support plugins? #49

Closed pimzand closed 2 years ago

pimzand commented 2 years ago

It may have become too complex to add helpers using plugins.

zzarne commented 2 years ago

My opinion: no. To implement a helper plugin one needs to understand so much of jack's inner workings that adding the helper to jack directly is not harder. Then sending a pull request allows others to benefit as well.

pimzand commented 2 years ago

Agreed. There are two example plugins. One for an alternative FreeDB server location, one for an alternative encoder. The alternative FreeDB server location shouldn't require a plugin, and an alternative encoder requires much more than just a helper definition.

We should probably remove the sample plugins, and maybe the plugin code too?

pimzand commented 2 years ago

fixed in c5d05b81e7aad727a056e936be4337fc5fcd31f5