search

jack-cli-cd-ripper / jack

Jack command-line CD ripper
GNU General Public License v2.0
14 stars 5 forks source link

support only python-discid as Python libdiscid wrapper #50

Closed pimzand closed 2 years ago

pimzand commented 2 years ago

The python3-mb branch of Jack depends on a C library called libdiscid (https://musicbrainz.org/doc/libdiscid). There are two competing Python wrappers for this library:

python-discid, using ctypes (no compilation) python-libdiscid, using cython (compiled)

@pimzand started coding using python-libdiscid, because that was available as a package in the distro he was using (Fedora). @zzarne added python-discid, because apparently, python-libdiscid cannot be installed using pip.

As a result, both libraries are now supported using a wrapper.

I propose we remove this wrapper and support python-discid directly, as the only supported wrapper. Because:

The benefits are:

zzarne commented 2 years ago

I don't see a python-discid package for Ubuntu (and probably Debian), only python-libdiscid. Getting rid of python-libdiscid would make it harder to package jack for those distributions.

pimzand commented 2 years ago

Indeed. I see there's a PPA for discid, but that may not be preferable. Interesting to see that Picard for Ubuntu depends on python3-libdiscid, where on Fedora it depends python3-discid. Arch Linux seems to support python-discid only... So let's leave it this way.

madmartin commented 2 years ago

Indeed. I see there's a PPA for discid, but that may not be preferable. Interesting to see that Picard for Ubuntu depends on python3-libdiscid, where on Fedora it depends python3-discid. Arch Linux seems to support python-discid only... So let's leave it this way.

And Gentoo offers

[U] dev-python/python-discid Available versions: 1.2.0 (~)1.2.0-r1^t {doc test PYTHON_TARGETS="python3_8 python3_9 python3_10"} Installed versions: 1.2.0(12:29:02 10/04/21)(-doc PYTHON_TARGETS="python3_9 python3_10 -python3_8") Homepage: https://github.com/JonnyJD/python-discid Description: Python bindings for libdiscid

[I] media-libs/libdiscid Available versions: 0.6.2 Installed versions: 0.6.2(00:38:22 09/11/20) Homepage: http://musicbrainz.org/doc/libdiscid Description: Client library to create MusicBrainz enabled tagging applications

pimzand commented 2 years ago

Updated the documentation in c1366fc245afb7d9c9f02a89519ea64ccbed2f7c