search

jack-cli-cd-ripper / jack

Jack command-line CD ripper
GNU General Public License v2.0
14 stars 5 forks source link

Feat ci #6

Closed madarche closed 7 years ago

madarche commented 7 years ago

This is ongoing work for #5

The tests are not passing at all because all the files are not conforming to PEP8. But it's a start on which to talk about.

@gaetano-guerriero should I modify all the files now so that they are PEP8 conformant?

gaetano-guerriero commented 7 years ago

I think we could run with pep8 || true to make test passes, and defer the style fixes.

BTW, we could run our test matrix with tox, and than in travis simply execute tox. This way we can locally replicate tests done by travis.

madarche commented 7 years ago

OK for tox. I'll set it up a bit later. Thanks

gaetano-guerriero commented 7 years ago

@madarche should we merge this as it is, and remove || true when files are fixed ? Anyway now there merge conflicts

madarche commented 7 years ago

@gaetano-guerriero I'll be working on it again in the next hours. I'll keep you informed. Sorry for the delay.

gaetano-guerriero commented 7 years ago

:+1: No problem

madarche commented 7 years ago

@gaetano-guerriero this is ready for you to review and hopefully to merge :-) This adds simple PEP8 fixes and a valid PEP8 tests in CI, even if there are many ignored PEP8 warnings. But at least it checks for real that no other warning and error types are introduced in the code base.

I'll be working on adding tox in another branch ASAP, so that the above modifications are not delayed anymore.

gaetano-guerriero commented 7 years ago

Wow that was gigantic. I made a comment on build-status icon

madarche commented 7 years ago

@gaetano-guerriero I've fixed the branch name for the CI. Well spotted! ;-) Merge it when you want if you find it's OK.

There are still many changes to do to be fully PEP8 compliant. The most part of the commited PEP8 fixes were done through autopep8 in safe mode. autopep8 --aggressive would produce more fixes. But again, the aim here is just to have a minimal safety net that we will increase as time goes by.

gaetano-guerriero commented 7 years ago

:+1: I'm merging now. I'm working on jack package grouping and I take this as starting point.

madarche commented 7 years ago

@gaetano-guerriero cool :-) I'm looking forward to see you work on this :-)

madarche commented 7 years ago

@gaetano-guerriero I still need to kickstart the Travis CI. It's just one more commit on a file. I'm doing that. It will be a commit on a text file so not to disturb your work on the code.

madarche commented 7 years ago

We now have our green "build passing" badge :-)