search

jack-mil / bing-rewards

A script to automate daily Bing rewards points
MIT License
177 stars 23 forks source link

`--bing` flag minor change #46

Closed znarfm closed 1 month ago

znarfm commented 2 months ago

Use ctrl + e instead of alt + d if the --bing flag is present, this ensures that every search attempt uses the default search engine set in the browser.

Function of each: Ctrl + e: Opens the address bar and uses the default search engine for the query Alt + d: Opens the address bar (can enter links)

Just a minor change to fix a minor problem. There can be times wherein a search term could be a name of a website. For example, when the query is youtube, the address bar would auto-append .com to it and just open YouTube; when using Ctrl + e, it uses the default search engine, which is Bing in this case, to search for youtube and not go to youtube.com

jack-mil commented 2 months ago

Thanks, this is a good catch. I don't use Edge or Bing, so I didn't know about this "feature".

znarfm commented 2 months ago

Heya! Just added your suggestions to my latest commit.

Chrome and Firefox both use this keyboard shortcut for opening address bar using the default search engine, so I think there won't be any problems for most people.

jack-mil commented 1 month ago

@znarfm Can you change the PR base branch to develop? Wanting to incorporate this in the next release.

znarfm commented 1 month ago

I have changed the base branch of this PR from master to develop as requested.