search

jack-pappas / ExtCore

An extended core library for F#.
Apache License 2.0
180 stars 32 forks source link

NuGet package installation adds binding redirect for FSharp.Core to version 4.3.0.0 #11

Closed vasily-kirichenko closed 7 years ago

vasily-kirichenko commented 9 years ago

What's worse, it replaces previous redirect with it's own:

before:

<dependentAssembly>
    <assemblyIdentity name="FSharp.Core" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
    <bindingRedirect oldVersion="0.0.0.0-4.3.1.0" newVersion="4.3.1.0" />
</dependentAssembly>

after:

<dependentAssembly>
    <assemblyIdentity name="FSharp.Core" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
    <bindingRedirect oldVersion="0.0.0.0-4.3.0.0" newVersion="4.3.0.0" />
</dependentAssembly>
jack-pappas commented 9 years ago

@vasily-kirichenko thank you for reporting this. I don't know what could be causing this, as the ExtCore package neither includes it's own app.config nor specifies any FSharp.Core dependency in it's .nuspec. Do you have any idea why this might be happening? Maybe NuGet is taking some action when it sees that ExtCore.dll references FSharp.Core, Version=4.3.0.0 and automatically generating the binding redirect (and overwriting the existing redirect to FSharp.Core, Version=4.3.1.0)?

jack-pappas commented 9 years ago

@vasily-kirichenko Is this still an issue for you, or can I close this? If you are still seeing this issue -- is it occurring with any other packages, or only with ExtCore?

I stumbled across Microsoft/visualfsharp#283 today -- perhaps that is related to this?

jack-pappas commented 7 years ago

This seems to have been a VS / VFT bug -- if you think this is still something that needs to be addressed in ExtCore, please let me know and I'll re-open the issue.