jack-pappas / ExtCore

An extended core library for F#.
Apache License 2.0
178 stars 32 forks source link

Update tests to use NUnit 3.x #25

Closed jack-pappas closed 6 years ago

jack-pappas commented 7 years ago

It'd be good to update the ExtCore.Tests project to use NUnit 3.x (it's currently using the last stable 2.x version). However, this isn't as simple as changing the reference because of the use of the [<ExpectedException>] attribute which was removed from NUnit 3.x.

There is a way to bring this attribute back for NUnit 3.x: https://github.com/nunit/nunit-csharp-samples/blob/master/ExpectedExceptionExample/ExpectedExceptionAttribute.cs

Let's either implement that attribute in ExtCore.Tests, or modify the tests to use e.g., Assert.Throws<T>(...) instead.

jack-pappas commented 6 years ago

@vasily-kirichenko completed this as part of #27.