search

jack-pappas / ExtCore

An extended core library for F#.
Apache License 2.0
178 stars 32 forks source link

Both Result and Choice for error handling #32

Open wallymathieu opened 6 years ago

wallymathieu commented 6 years ago
wallymathieu commented 6 years ago

Note that I've added same kind of test as can be found for Fold for FoldBack @jack-pappas

wallymathieu commented 6 years ago

@vasily-kirichenko and @jack-pappas thoughts? Does it look ok?

jack-pappas commented 6 years ago

Thanks @wallymathieu — I’ll take a look at this over the weekend.

vasily-kirichenko commented 6 years ago

@jack-pappas could you please publish a new NuGet package after merging this PR?

wallymathieu commented 6 years ago

https://gist.github.com/wallymathieu/ad8fe3d5b85875cf6f487ad0180be660 ?

wallymathieu commented 6 years ago

Should we perhaps try to split this pull request into more granular parts? A lot changes are mostly copy and modify (in order to be compatible). @vasily-kirichenko do you have an idea of how this could be done?

vasily-kirichenko commented 6 years ago

Is there a plan to merge this?

wallymathieu commented 6 years ago

Should we close this pull request @jack-pappas (as it is to big) ?

wallymathieu commented 6 years ago

I'm closing this PR as it is probably to big to review or accept. Best of luck!

vasily-kirichenko commented 5 years ago

@jack-pappas Please, merge this PR. I had to build an ExtCore package myself and publish it on a private server, everything's been working OK.

wallymathieu commented 5 years ago

Since @vasily-kirichenko says that it's working fine, I've reopened the pull request

vasily-kirichenko commented 5 years ago

Yes, it's working 100% fine.

wallymathieu commented 5 years ago

Then perhaps move this PR to point to another branch on this repository in order to iterate on it?

vasily-kirichenko commented 5 years ago

@wallymathieu Could you merge master into it to make AppVeyor happy?

wallymathieu commented 5 years ago

Will do!