search

jack-pappas / ExtCore

An extended core library for F#.
Apache License 2.0
178 stars 32 forks source link

net45 tests fail #35

Closed wallymathieu closed 6 years ago

wallymathieu commented 6 years ago

Could perhaps be due to https://github.com/nunit/nunit/issues/2518

jindraivanek commented 6 years ago

What is failing for you? Travis build is OK, I tried tests locally (Windows) and it is also OK.

wallymathieu commented 6 years ago

Try removing everything except net45 in targetframeworks for the tests and run the tests on windows. It's failing on appveyor.

jindraivanek commented 6 years ago

Still no failing test. Looking at appveyor log https://ci.appveyor.com/project/jack-pappas/extcore/build/0.0.47, tests succeeds, but after that it returns error code.

wallymathieu commented 6 years ago

Weird. Could the build error be due to the build of C:\projects\extcore\ExtCore.Tests\bin\Debug\netstandard1.6\ExtCore.Tests.dll, as that should be netcoreapp and not netstandard?

wallymathieu commented 6 years ago

I tried to build it here: https://github.com/wallymathieu/ExtCore/tree/appveyor_trial But that could perhaps be related to some other type of failure

wallymathieu commented 6 years ago

Thanks for the help and patience @jindraivanek ! 😄