jack0402 / csipsimple

Automatically exported from code.google.com/p/csipsimple
0 stars 0 forks source link

Send broadcast to Callmeter 3G #893

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Android call log does not allow differentiation between SIP and cell phone 
calls.

Callmeter 3G (http://code.google.com/p/callmeter) is using a broadcast receiver 
to recognize a SIP call. This would allow Callmeter 3G to handle voip calls 
separately from cell phone calls.

It would be great, if CSipSimple can send this broadcast, too. Maybe there 
could be an option to send or not send the broadcast.

See issue #290 of Callmeter 3G 
(http://code.google.com/p/callmeter/issues/detail?id=290) for more details of 
the broadcast.

Original issue reported on code.google.com by friehm...@googlemail.com on 17 Apr 2011 at 10:02

GoogleCodeExporter commented 9 years ago
Ok, 
Better than an option I think that simply scanning at first run time if there 
is receiver for this intent is the good way to do.

Some questions about the intent :
 * I see in the sipdroid patch a "EXTRA_SIP_PROVIDER" what do you expect here? I can provide the account name as a String but I'm not sure you expect a "name".
 * How do you merge info between the call log item and the broadcasted intent? I think it should be possible for me to send (inside the intent) the calllog id I have just inserted.
 * Or maybe dependiing on what is exactly the feature you want to have in Callmeter 3g, it's maybe not the good way to think about android call logs records :
   * Csipsimple allow users to not add records to call logs
   * CSipSimple does not add call logs record to the stock phone app if the sip uri can not be parsed as a "phone number". 
--> As consequence you may miss some call records. On the other side, I can 
send in the intent the *exact* infos about :
   * time spend on this call
   * data usage of media packets for this call
   * And many other info we could add.

 * How should we manage multiple calls? I mean, CSipSimple will support conferencing and multiple calls in next release, it will add 2 entries in call logs. Can this break the feature provided by Callmeter 3g?

 * Last but not least, you really should consider ask OpenIntents guys to add this intent to the openintent project (http://www.openintents.org/en/intentstable). 
And try to "normalize" the intent so that not only callmeter 3g can support it 
and besides it will be more clear for all sip application that this intent 
should be raised . It would avoid to have 3 apps doing the same thing 
requesting to implement their own intent. As sipdroid already support it and as 
CSipSimple will support it too and as besides callmeter is GPLv3, I think there 
will be no problem at all to make this as the normalized way to announce a sip 
call log record.
Doing that - the normalization task - would also introduce new intent options 
that may be useful. I guess we should discuss about what is the feature we want 
to produce and what is the best way to do that using an intent producing as 
much intent extras as necessary to cover all use cases. 
Maybe even, we should not think only about sip but also about other voice over 
IP calls, or even other "datas" calls - I don't know that's just suggestions, 
but I really think we should not think only "one specific app that talk to 
another specific app".

Original comment by r3gis...@gmail.com on 17 Apr 2011 at 12:44

GoogleCodeExporter commented 9 years ago
Issue 922 has been merged into this issue.

Original comment by r3gis...@gmail.com on 3 May 2011 at 10:12

GoogleCodeExporter commented 9 years ago
Now call meter 3G has the save_sip call reciever.

So, fixing consists in sending broadcast 
"de.ub0r.android.callmeter.SAVE_SIPCALL"

I'll ask on their issue list if some parameters are required and more important 
if it could be added to openintent project or add something more documented.

Original comment by r3gis...@gmail.com on 3 May 2011 at 10:15

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r824.

Original comment by r3gis...@gmail.com on 3 May 2011 at 11:29